Skip to content

fix(desktop): keep windows process PATH for managed agents#2354

Open
Chessing234 wants to merge 1 commit into
block:mainfrom
Chessing234:fix/windows-runtime-path
Open

fix(desktop): keep windows process PATH for managed agents#2354
Chessing234 wants to merge 1 commit into
block:mainfrom
Chessing234:fix/windows-runtime-path

Conversation

@Chessing234

Copy link
Copy Markdown

Summary

  • on Windows, login_shell_path() returns None on purpose so children inherit the real PATH
  • build_augmented_path still returned a managed-only PATH (~/.local/bin + exe parent), and runtime overwrote the child PATH with it
  • system Node then disappeared ('"node"' is not recognized)
  • when shell PATH is missing, append the process PATH; add regression tests

Closes #2327

Test plan

  • unit tests for process-PATH fallback / shell-path preference
  • on Windows with system Node only: launch a Claude Code managed agent and confirm harness starts

Made with Cursor

@Chessing234
Chessing234 requested a review from a team as a code owner July 22, 2026 10:58
@Chessing234

Copy link
Copy Markdown
Author

when login-shell path is missing on windows we now append the process path so system node stays visible.

@Chessing234
Chessing234 force-pushed the fix/windows-runtime-path branch 2 times, most recently from 5871768 to 3b92074 Compare July 22, 2026 11:01
Signed-off-by: Taksh <takshkothari09@gmail.com>
@Chessing234
Chessing234 force-pushed the fix/windows-runtime-path branch from 3b92074 to 01119a3 Compare July 22, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Windows: managed-agent harness fails to launch — runtime PATH override drops system Node ("node" is not recognized)

1 participant