fix(desktop): keep windows process PATH for managed agents#2354
Open
Chessing234 wants to merge 1 commit into
Open
fix(desktop): keep windows process PATH for managed agents#2354Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
Author
|
when login-shell path is missing on windows we now append the process path so system node stays visible. |
Chessing234
force-pushed
the
fix/windows-runtime-path
branch
2 times, most recently
from
July 22, 2026 11:01
5871768 to
3b92074
Compare
Signed-off-by: Taksh <takshkothari09@gmail.com>
Chessing234
force-pushed
the
fix/windows-runtime-path
branch
from
July 22, 2026 11:02
3b92074 to
01119a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
login_shell_path()returnsNoneon purpose so children inherit the real PATHbuild_augmented_pathstill returned a managed-only PATH (~/.local/bin+ exe parent), and runtime overwrote the child PATH with it'"node"' is not recognized)Closes #2327
Test plan
Made with Cursor